fix: change output selection and dust threshold logic #2065
+12
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keychain::Internal
instead of.last()
- avoids random external change or panics when no internal descriptor is present.DrainWeights
now matches the change address type (taproot, segwit, legacy) for accurate fee and dust estimates.>
to>=
so exact dust-sized change isn’t lost to fees.Notes to the reviewers
small but important cleanup for more predictable change handling and fee estimation. Worth double-checking test coverage for non-taproot outputs.
Changelog notice
fix incorrect change keychain selection, fee estimation, and dust threshold comparison.
Checklists
All Submissions:
New Features:
Bugfixes: