Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to return the version of BDK at runtime #271

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

afilini
Copy link
Member

@afilini afilini commented Jan 25, 2021

Description

This can be used in a few different ways:

  • For dynamically-linked libraries this can be used to determine at runtime if the version of BDK is compatible, i.e. if it's the same an executable was linked against originally
  • We can print this in bdk-cli or other tools

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

@notmandatory
Copy link
Member

ACK df32c84. I'll add a bdk-cli command for it. 😃

@afilini afilini merged commit df32c84 into bitcoindevkit:master Jan 26, 2021
@afilini afilini deleted the feat/version-function branch January 26, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants