Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening against the relase branch, as this is a bugfix instead of a new feature. Once the release is done it'll get merged back into
master
.[policy] Allow specifying a policy path for
Multisig
While technically it's not required since there are no timelocks inside, it's still less confusing for the end user if we allow this instead of failing like we do currently.
[policy] Remove the
TooManyItemsSelected
errorThe
TooManyItemsSelected
error has been removed, since it's not technically an error but potentailly more of an "over-constraint" over a tx: for instance, given athresh(3,pk(a),pk(b),older(10),older(20))
descriptor one could create a spending tx with the[0,1,2]
items that would only be spendable after10
blocks, or a tx with the[0,2,3]
items that would be spendable after20
.In this case specifying more items than the threshold would create a tx with the maximum constraint possible, in this case the
20
blocks. This is not necessarily an error, so we should allow it without failing.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
CHANGELOG.md
Bugfixes: