Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rpc] Show in the docs that the RPC APIs are feature-gated #389

Merged
merged 1 commit into from
Jul 12, 2021
Merged

[rpc] Show in the docs that the RPC APIs are feature-gated #389

merged 1 commit into from
Jul 12, 2021

Conversation

afilini
Copy link
Member

@afilini afilini commented Jul 9, 2021

Description

Show in the docs that in order to use the API under the blockchain::rpc module the rpc feature has to be enabled.

Not sure if it's worth doing a patch-level release just to fix this, I don't think it's that big of an issue.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

notmandatory
notmandatory approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. It's not a bug fix so I think this can wait for the next normal release.

@afilini afilini merged commit 22f4db0 into bitcoindevkit:master Jul 12, 2021
@afilini afilini deleted the fix/rpc-docs-feature-gate branch July 12, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afilini @notmandatory