Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codecov@v2 #458

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Update codecov@v2 #458

merged 1 commit into from
Nov 8, 2021

Conversation

rajarshimaitra
Copy link
Contributor

Description

Fixes #447.

Notes to the reviewers

Some checks are failing on current master.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@rajarshimaitra
Copy link
Contributor Author

rust version 1.46.0 is failing build test is failing, even in current master.

@notmandatory
Copy link
Member

I think it's time to update our MSRV, what are your thoughts for #457? This should fix the build issues we've been getting lately.

@afilini
Copy link
Member

afilini commented Oct 26, 2021

Try rebasing on #454 first, that should fix the CI

@rajarshimaitra
Copy link
Contributor Author

Rebased on #457, CI passing now.

@notmandatory
Copy link
Member

Rebased on #457, CI passing now.

Sorry this should be rebased on master which now includes #454, without including 36fe4f4. We need to discuss #457 and MSRV changes in our next team chat.

@rajarshimaitra
Copy link
Contributor Author

Thanks. Rebased on master.

@notmandatory
Copy link
Member

Now you just need to do a git rebase -i HEAD~2 and drop commit d430420.

@rajarshimaitra
Copy link
Contributor Author

Ok, Does this look correct?

notmandatory
notmandatory approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3b2b559

@afilini afilini merged commit d21b6e4 into bitcoindevkit:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.14.0 Feature Freeze
Development

Successfully merging this pull request may close these issues.

Upgrade Github Actions workflow to use codecov-action@v2
3 participants
@rajarshimaitra @notmandatory @afilini