Add data as output (via OP_RETURN) #460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add a method
fn add_data(&mut self, data: &[u8])
to the TxBuilder as a shortcut to build an op_return output.Notes to the reviewers
To allow sending outputs with 0 value, the dust check has been modified, excluding from the check scripts that are provably unspendable.
As briefly discussed in the call, while using op_return may be controversial, it exists and it's always better than the alternative for embedding data. For this reasons wallet like bitcoin core and electrum allow to create transactions with it
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
CHANGELOG.md