Deprecate Database::flush() function #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmandatory
force-pushed
the
deprecate/db_flush
branch
3 times, most recently
from
f07abb6 to
b61a61f
Compare
The Database::flush() function is only needed for the sled database on mobile, instead for mobile use the sqlite database.
notmandatory
force-pushed
the
deprecate/db_flush
branch
from
b61a61f to
a111d25
Compare
|
Rebased and ready to review. |
afilini
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Database::flush() function is only needed for the sled database on mobile, instead for mobile use the sqlite database.
Notes to the reviewers
This PR is in preparation for removing the Database::flush() function. See #575 (comment).
After the
release/0.18.0feature freeze branch is created then #575 should be merged.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.md