Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin transitive dependency 'http' to version 0.2.6 #595

Closed
wants to merge 1 commit into from

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Apr 29, 2022

Description

This is required because http (a transitive dependency of reqwest) changed their MSRV to 1.49 and bdk MSRV is still 1.46.

Notes to the reviewers

The http dependency MSRV was change in http version 0.2.7 released on April 28, 2022.

% cargo tree --all-features -i http                                       
http v0.2.7
├── bdk v0.19.0-dev (/home/steve/git/notmandatory/bdk)
├── h2 v0.3.13
│   ├── hyper v0.14.18
│   │   ├── hyper-tls v0.5.0
│   │   │   └── reqwest v0.11.10
│   │   │       └── bdk v0.19.0-dev (/home/steve/git/notmandatory/bdk)
│   │   └── reqwest v0.11.10 (*)
│   └── reqwest v0.11.10 (*)
├── http-body v0.4.4
│   ├── hyper v0.14.18 (*)
│   └── reqwest v0.11.10 (*)
├── hyper v0.14.18 (*)
└── reqwest v0.11.10 (*)

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

This is required because it's MSRV has been updated to 1.49 and bdk
MSRV is still 1.46.
@notmandatory
Copy link
Member Author

Closing in favor of #593 which will bump MSRV to 1.51 for rust-electrum-client feature.

@notmandatory notmandatory removed this from the Release 0.19.0 Feature Freeze milestone May 11, 2022
@notmandatory notmandatory deleted the pin_http_026 branch October 24, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant