-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to rust-bitcoin 0.28 #606
Merged
afilini
merged 2 commits into
bitcoindevkit:master
from
afilini:upgrade/rust-bitcoin-0.28
May 12, 2022
Merged
Upgrade to rust-bitcoin 0.28 #606
afilini
merged 2 commits into
bitcoindevkit:master
from
afilini:upgrade/rust-bitcoin-0.28
May 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed861c5
to
f92029d
Compare
rajarshimaitra
suggested changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review + tACK f92029d
modulo one deprecation warning in cargo clippy when you run
cargo clippy --all-targets --features compact_filters --no-default-features -- -D warnings
error: use of deprecated associated function `bitcoin::network::stream_reader::StreamReader::<R>::new`: wrap your stream into a buffered reader if necessary and use consensus_encode directly
--> src/blockchain/compact_filters/peer.rs:330:40
|
330 | let mut reader = StreamReader::new(connection, None);
| ^^^
|
= note: `-D deprecated` implied by `-D warnings`
error: use of deprecated associated function `bitcoin::network::stream_reader::StreamReader::<R>::read_next`: wrap your stream into a buffered reader if necessary and use consensus_encode directly
--> src/blockchain/compact_filters/peer.rs:332:75
|
332 | let raw_message: RawNetworkMessage = check_disconnect!(reader.read_next());
| ^^^^^^^^^
error: could not compile `bdk` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: build failed
f92029d
to
0016458
Compare
rajarshimaitra
approved these changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 0016458
notmandatory
pushed a commit
to bitcoindevkit/rust-esplora-client
that referenced
this pull request
Aug 2, 2022
00164588f2ddab91bb4468ec010dc1bbca277eb5 Stop using deprecated structs (Alekos Filini) 299b700 Upgrade to rust-bitcoin 0.28 and miniscript 7.0 (Alekos Filini) Pull request description: ### Description Upgrade all our dependencies to work with the new release of rust-bitcoin ### Notes to the reviewers The commits in this pr were originally part of #593 ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [x] I've updated `CHANGELOG.md` ACKs for top commit: rajarshimaitra: ACK 00164588f2ddab91bb4468ec010dc1bbca277eb5 Tree-SHA512: eef7e94246e619686b4dfffd6e4cb685630fe2eaf9447f2f0b49ed2643d67f81c50e0d89b66267db4552a05e58f638d885eb7056270648403f716803fce9e275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade all our dependencies to work with the new release of rust-bitcoin
Notes to the reviewers
The commits in this pr were originally part of #593
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
CHANGELOG.md