Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rust-bitcoin 0.28 #606

Merged
merged 2 commits into from
May 12, 2022

Conversation

afilini
Copy link
Member

@afilini afilini commented May 12, 2022

Description

Upgrade all our dependencies to work with the new release of rust-bitcoin

Notes to the reviewers

The commits in this pr were originally part of #593

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've updated CHANGELOG.md

@afilini afilini force-pushed the upgrade/rust-bitcoin-0.28 branch from ed861c5 to f92029d Compare May 12, 2022 10:58
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review + tACK f92029d

modulo one deprecation warning in cargo clippy when you run

cargo clippy --all-targets --features compact_filters --no-default-features -- -D warnings
error: use of deprecated associated function `bitcoin::network::stream_reader::StreamReader::<R>::new`: wrap your stream into a buffered reader if necessary and use consensus_encode directly
   --> src/blockchain/compact_filters/peer.rs:330:40
    |
330 |         let mut reader = StreamReader::new(connection, None);
    |                                        ^^^
    |
    = note: `-D deprecated` implied by `-D warnings`

error: use of deprecated associated function `bitcoin::network::stream_reader::StreamReader::<R>::read_next`: wrap your stream into a buffered reader if necessary and use consensus_encode directly
   --> src/blockchain/compact_filters/peer.rs:332:75
    |
332 |             let raw_message: RawNetworkMessage = check_disconnect!(reader.read_next());
    |                                                                           ^^^^^^^^^

error: could not compile `bdk` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: build failed

@afilini afilini force-pushed the upgrade/rust-bitcoin-0.28 branch from f92029d to 0016458 Compare May 12, 2022 15:32
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0016458

@afilini afilini merged commit e548653 into bitcoindevkit:master May 12, 2022
notmandatory pushed a commit to bitcoindevkit/rust-esplora-client that referenced this pull request Aug 2, 2022
00164588f2ddab91bb4468ec010dc1bbca277eb5 Stop using deprecated structs (Alekos Filini)
299b700 Upgrade to rust-bitcoin 0.28 and miniscript 7.0 (Alekos Filini)

Pull request description:

  ### Description

  Upgrade all our dependencies to work with the new release of rust-bitcoin

  ### Notes to the reviewers

  The commits in this pr were originally part of #593

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [x] I've updated `CHANGELOG.md`

ACKs for top commit:
  rajarshimaitra:
    ACK 00164588f2ddab91bb4468ec010dc1bbca277eb5

Tree-SHA512: eef7e94246e619686b4dfffd6e4cb685630fe2eaf9447f2f0b49ed2643d67f81c50e0d89b66267db4552a05e58f638d885eb7056270648403f716803fce9e275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants