Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate the redeemScript for sh(wsh(sortedmulti())) #610

Merged
merged 1 commit into from
May 24, 2022

Conversation

afilini
Copy link
Member

@afilini afilini commented May 23, 2022

Description

Also explicitly match all the individual variants to ensure a similar problem
doesn't happen again.

Fixes #609

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Also explicitly match all the individual variants to ensure a similar problem
doesn't happen again.

Fixes bitcoindevkit#609
@notmandatory notmandatory added this to the Release 0.18.1 milestone May 23, 2022
@notmandatory
Copy link
Member

It looks like this fix includes the TR type so it must be dependent on rust-bitcoin 0.28 and rust-miniscript 7.0, so that means we if we wanted to release it in a fix release we'd need some small change to work with the older versions of those dependencies right? Since @ulrichard isn't held up waiting for this I'm now leaning towards releasing it with the next regular release instead of a 0.18.1 fix release.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 82de8b5

@afilini
Copy link
Member Author

afilini commented May 24, 2022

Yeah that's true, he said it's not blocking on discord so I would just go ahead and merge this.

Thanks for the review!

@afilini afilini merged commit 87b0745 into bitcoindevkit:master May 24, 2022
@notmandatory notmandatory modified the milestones: Release 0.18.1, Release 0.19.0 Feature Freeze May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some PSBTs from BDK don't load in Electrum
2 participants