Add assertions in the FeeRate constructor #694
Merged
+52
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afilini
force-pushed
the
fix/feerate-assertions
branch
2 times, most recently
from
36f7427 to
00e5c1d
Compare
kaiwolfram
reviewed
Aug 1, 2022
20 tasks
afilini
force-pushed
the
fix/feerate-assertions
branch
from
00e5c1d to
4dbd2bd
Compare
Disallow negative, NaN, infinite or subnormal fee rate values.
afilini
force-pushed
the
fix/feerate-assertions
branch
from
4dbd2bd to
235011f
Compare
|
re-ACK 235011f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disallow negative, NaN, infinite or subnormal fee rate values.
Notes to the reviewers
This commit is technically an API break because it makes the
FeeRate::from_sat_per_vbfunction non-const. I think it's worth it compared to the risk of having completely nonsensical fee rates (that can break the coin selection in interesting ways).EDIT: it's also a breaking change because our code can now panic in scenarios where it didn't before. Again, I think it's worth it.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: