-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mnemonic_to_descriptors example #746
Add mnemonic_to_descriptors example #746
Conversation
fc0ef04
to
c7eec1c
Compare
1efe7fb
to
2d67e10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.. Thanks for writing this.. Would be a really helpful example.. Few comments below..
I agree with Raj that this example should also cover creating the actual descriptor, instead of stopping at the xprv However, you don't really need to manipulate the mnemonic that much to create a descriptor with bdk, as the
This greatly simplifies your whole example, and I think it's the right way to go, as it shows how powerful the |
256b1f1
to
a2a09bb
Compare
Thanks @danielabrozzoni for helping me with the debugging! @notmandatory this was built on top of #800. |
d5469ec
to
2470305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 2470305
I will go through the network fix more closely later.. If this is scheduled for 0.25, I think this can go in now..
I merged PR #800, go ahead and re-base this PR, just to make sure the history will look good. |
This was initially requested by one user but might be relevant for other users as well.
2470305
to
df905a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK df905a8
Description
Using bdk-cli it is simple for a new user to generate a mnemonic phrase and descriptors. This might
not be clear for new users when using bdk itself.
Notes to the reviewers
This was initially requested by one user but might be relevant for other users as well.
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
Bugfixes: