-
Notifications
You must be signed in to change notification settings - Fork 20
deps!: update bdk_chain
to 0.22.0
#208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ValuedMammal
wants to merge
2
commits into
bitcoindevkit:master
Choose a base branch
from
ValuedMammal:deps/update-bdk-chain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
deps!: update bdk_chain
to 0.22.0
#208
ValuedMammal
wants to merge
2
commits into
bitcoindevkit:master
from
ValuedMammal:deps/update-bdk-chain
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14781237238Details
💛 - Coveralls |
Why is this part of the 1.3 milestone and not 2.0? |
evanlinjin
reviewed
Apr 15, 2025
I renamed the old milestones so had to put this one back on the new 2.0. |
2fceda8
to
a60d70d
Compare
bdk
at revision b7075865bdk
at revision 4fe121e7
bdk
at revision 4fe121e7bdk_chain
to 4fe121e7
c83afda
to
c2d27c0
Compare
`once_cell` remains pinned to 1.20.3
c2d27c0
to
a247215
Compare
bdk_chain
to 4fe121e7bdk_chain
to 0.22.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
bdk_chain
dependency to the latest version 0.22.0Notes to the reviewers
This PR doesn't make use of
CanonicalizationParams
for any advanced use cases - instead we rely on the default params for all tx-graph queries.fixes #202
fixes #224
Changelog notice
bdk_chain
to 0.22.0bdk_file_store
to 0.20.0Added
start_sync_with_revealed_spks_at
start_full_scan_at
Changed
start_sync_with_revealed_spks
is feature gated by "std", as it uses the system time to provide the time of the sync and also the tx last-seen.apply_update
no longer requires std, as the timestamp is provided in the sync / full scan requeststart_full_scan
is also gated behind "std"start_sync_*
now includes the expected SPK history (vialist_expected_spk_txids
)Removed
apply_update_at
BREAKING
bdk_core::TxUpdate
is non-exhaustive Make full-scan/sync flow easier to reason about. bdk#1838FileStoreError
is changed to hold a new inner type Refactor file store bdk#1684Changes to persisted data
The
tx_graph::ChangeSet
gained a new default-able fieldlast_evicted
to persist the fact that a tx is no longer part of the canonical chain.TODO
example_wallet_rpc
to use newexpected_mempool_txids
functionality.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing