Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): pin native-tls to 0.2.13 and flate2 to 1.0.35 #116

Merged

Conversation

oleonardolima
Copy link
Collaborator

@oleonardolima oleonardolima commented Feb 26, 2025

Description

In the latest native-tls release 0.2.14 it's bumped their MSRV version to 1.80.0.

It's not a direct dependency, however, it comes as a transitive dependency from reqwest.

Alongside that, the flate2 dependency also bumped their MSRV to 1.67.0 which also requires pinning its version to 1.0.35.

This PR pins on CI both the native-tls to 0.2.13, and flate2 to 1.0.35, and updates the instruction on README.md in order to properly build on MSRV.

Notes to the reviewers

Changelog notice

  • Adds native-tls 0.2.13 to MSRV pinning step on CI.
  • Adds flate2 1.0.35 to MSRV pinning step on CI.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@coveralls
Copy link

coveralls commented Feb 26, 2025

Pull Request Test Coverage Report for Build 13551188773

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 88.167%

Files with Coverage Reduction New Missed Lines %
src/api.rs 1 53.03%
Totals Coverage Status
Change from base Build 12165803391: -0.2%
Covered Lines: 1140
Relevant Lines: 1293

💛 - Coveralls

@oleonardolima oleonardolima changed the title fix(ci): pin native-tls to 0.2.13 fix(ci): pin native-tls to 0.2.13 and flate2 to 1.0.35 Feb 26, 2025
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 84161ba

@ValuedMammal ValuedMammal merged commit 9c9e7a5 into bitcoindevkit:master Feb 26, 2025
25 checks passed
@oleonardolima oleonardolima deleted the ci/pin-native-tls-to-0.2.13 branch March 20, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants