[deps] Update electrsd to 0.33.0
#120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14598241558Details
💛 - Coveralls |
ValuedMammal
force-pushed
the
deps/bump-electrsd
branch
from
0780429 to
2a5d7fb
Compare
ValuedMammal
changed the title
electrsd to 0.32electrsd to 0.32
ValuedMammal
force-pushed
the
deps/bump-electrsd
branch
from
2a5d7fb to
0e02d79
Compare
|
For unit tests
|
ValuedMammal
changed the title
electrsd to 0.32electrsd to 0.32.0
| assert_eq!(tx_info.status.block_height, tx_res.info.blockheight); | ||
| assert_eq!(tx_info.status.block_hash, tx_res.info.blockhash); | ||
| assert_eq!(tx_info.status.block_time, tx_res.info.blocktime); | ||
| // TODO(corepc): No .block_height field on GetTransaction ? |
There was a problem hiding this comment.
Oh, it's unfortunate, might take the opportunity and add it too as I need to finish my work on adding the other mining RPCs required for the BDK upgrade.
oleonardolima
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
tACK 0e02d79
It looks pretty straight-forward, with the two caveats of block_height and block_time fields.
|
ACK e732a5b |
|
If we choose to release this one in |
ValuedMammal
force-pushed
the
deps/bump-electrsd
branch
from
e732a5b to
c52662d
Compare
ValuedMammal
changed the title
electrsd to 0.32.0electrsd to 0.33.0
ValuedMammal
force-pushed
the
deps/bump-electrsd
branch
from
c52662d to
a64be62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
electrsddev dependency to 0.32.0Updated pinned deps needed to build on rust 1.63.0
fixes #119
fixes #117