Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump electrsd to 0.26 + bitcoind_25_0 and fix msrv errors #76

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Feb 3, 2024

This PR bumps electrsd to 0.26 and replaces temporary dependency on bitcoin-internals with hex-conservative as done in #75. Fixed CI MSRV issues with dev dependencies blocking #75 and #74.

@notmandatory notmandatory added the ci Continuous Integration issues label Feb 3, 2024
@notmandatory notmandatory added this to the Release 0.7.0 milestone Feb 3, 2024
@notmandatory notmandatory self-assigned this Feb 3, 2024
@notmandatory notmandatory force-pushed the bump_electrsd branch 2 times, most recently from c20ed68 to 06f6bca Compare February 3, 2024 23:22
@notmandatory notmandatory marked this pull request as draft February 4, 2024 01:31
@notmandatory
Copy link
Member Author

For some reason with the default feature set the tests aren't completing so I moved this to draft until I get that figured out.

Copy link

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 06f6bca

@notmandatory notmandatory marked this pull request as ready for review February 5, 2024 00:15
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7777789071

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.1%) to 78.934%

Files with Coverage Reduction New Missed Lines %
src/lib.rs 1 97.49%
src/api.rs 10 14.49%
Totals Coverage Status
Change from base Build 7383678843: -1.1%
Covered Lines: 918
Relevant Lines: 1163

💛 - Coveralls

@notmandatory
Copy link
Member Author

To get the default feature tests to run without locking up I had to limit test threads to 1.

@storopoli
Copy link

To get the default feature tests to run without locking up I had to limit test threads to 1.

Have you tried 2?
I've managed to get away with 2 in GH Action runners in the past.

@notmandatory
Copy link
Member Author

To get the default feature tests to run without locking up I had to limit test threads to 1.

Have you tried 2? I've managed to get away with 2 in GH Action runners in the past.

Two would probably work, but it runs fast enough with 1 so I don't see a need to push it.

Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ac2fd86

@tcharding tcharding mentioned this pull request Feb 7, 2024
Copy link
Contributor

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ac2fd86

@notmandatory notmandatory merged commit 7faab65 into bitcoindevkit:master Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants