Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hex dependency version, set to 0.2.0 #82

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix hex dependency version, set to 0.2.0 #82

merged 1 commit into from
Mar 21, 2024
+1 −1

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Mar 21, 2024 •
edited
Loading

We need to set a version for the hex dependency, crates.io does not let us publish a package with an * version.

@notmandatory notmandatory self-assigned this Mar 21, 2024
@notmandatory notmandatory added the bug Something isn't working label Mar 21, 2024
@notmandatory notmandatory added this to the Release 0.7.0 milestone Mar 21, 2024
@coveralls
Copy link

coveralls commented Mar 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8379354783

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.568%
Totals Coverage Status
Change from base Build 8368123947: 0.0%
Covered Lines: 959
Relevant Lines: 1134
💛 - Coveralls

storopoli
storopoli reviewed Mar 21, 2024
View reviewed changes
oleonardolima
oleonardolima approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@oleonardolima oleonardolima left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b55ec14

but mind storopoli's comment as well :)

oleonardolima
oleonardolima approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 811ff7e

storopoli
storopoli approved these changes Mar 21, 2024
View reviewed changes
Copy link

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 811ff7e

vladimirfomene
vladimirfomene approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@vladimirfomene vladimirfomene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 811ff7e

@notmandatory notmandatory merged commit d6bff85 into master Mar 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirfomene vladimirfomene

@oleonardolima oleonardolima

@storopoli storopoli

Assignees

@notmandatory notmandatory

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@notmandatory @coveralls @vladimirfomene @oleonardolima @storopoli