(EGG-141) resolve incorrect token references and missing border-radius in tailwind output#97
Open
(EGG-141) resolve incorrect token references and missing border-radius in tailwind output#97
Conversation
snoattoh
temporarily deployed
to
preview-fix-output-bugs
GitHub Actions
Inactive
|
🎉 Preview Deployed! |
m-thompson-code
requested changes
Feb 17, 2026
Collaborator
m-thompson-code
left a comment
m-thompson-code
left a comment
There was a problem hiding this comment.
can we remove the scary import type and refactor to import the type on the top of the file?
| tokens: [styleToken], | ||
| }, | ||
| ] as unknown as ReturnType< | ||
| typeof import('../../../transformers/variants/convert-variant-group-by').convertVariantGroupBy |
Collaborator
There was a problem hiding this comment.
this looks scary, can we move the import to the top of the file?
import type { convertVariantGroupBy } from '../../../transformers/variants/convert-variant-group-by';you might still need to do typeof convertVariantGroupBy
if it's actually being used in the unit tests file outside of just types, you can drop the "type" from the import
snoattoh
temporarily deployed
to
preview-fix-output-bugs
GitHub Actions
Inactive
snoattoh
force-pushed
the
fix/output-bugs
branch
from
8b246fe to
c1836f2
Compare
snoattoh
temporarily deployed
to
preview-fix-output-bugs
GitHub Actions
Inactive
snoattoh
temporarily deployed
to
preview-fix-output-bugs
GitHub Actions
Inactive
|
🎉 Preview Deployed! |
snoattoh
temporarily deployed
to
preview-fix-output-bugs
GitHub Actions
Inactive
snoattoh
temporarily deployed
to
preview-fix-output-bugs
GitHub Actions
Inactive
|
🎉 Preview Deployed! |
snoattoh
temporarily deployed
to
preview-fix-output-bugs
GitHub Actions
Inactive
|
🎉 Preview Deployed! |
snoattoh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.