Cpu C++ kernel #1789
Open
Cpu C++ kernel #1789
+649
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Signed-off-by: jiqing-feng <[email protected]>
Comment on lines
272
to
286
| if (BUILD_CPU) | ||
| target_link_libraries(bitsandbytes PRIVATE OpenMP::OpenMP_CXX) | ||
| include(CheckCXXCompilerFlag) | ||
|
|
||
| check_cxx_compiler_flag(-mavx512f HAS_AVX512F) | ||
| check_cxx_compiler_flag(-mavx512bf16 HAS_AVX512BF16) | ||
|
|
||
| if(HAS_AVX512F) | ||
| target_compile_options(bitsandbytes PRIVATE -mavx512f) | ||
| endif() | ||
|
|
||
| if(HAS_AVX512BF16) | ||
| target_compile_options(bitsandbytes PRIVATE -mavx512bf16) | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
Hi @jiqing-feng we still have some build issues with this.
A few things need consideration here:
- We build for Linux aarch64
- We also build for macOS arm64. I'm not sure how to use OpenMP on that platform - maybe we can skip for now?
- On Windows x86-64 we build with MSVC. Apart from
/arch:AVX512I don't really know if there is a flag for AVX512-BF16.
There was a problem hiding this comment.
I have updated the cmake file, please check it. Thanks.
Signed-off-by: jiqing-feng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++ kernels.
cmake -DCOMPUTE_BACKEND=cpu -S . && makeHi @matthewdouglas . I've implemented the CPU dequantize op for nf4/fp4. It will bring 10x+ speed-up in the e2e text-generation task compared with the original python kernel on llama3-8B model. Would you please review this PR? Thanks!