Skip to content

Conversation

@david-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR cleans up a handful of small deprecation's throughout the app. There should be no visual changes in this PR.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@claude
Copy link

claude bot commented Oct 29, 2025

Claude Code is working…

I'll analyze this and get back to you.

View job run

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailse9f3473d-1e5e-43a9-b59d-cce609ea776d

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.81%. Comparing base (290f594) to head (f40ba8f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...n/ui/platform/util/WindowAdaptiveInfoExtensions.kt 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6096   +/-   ##
=======================================
  Coverage   84.81%   84.81%           
=======================================
  Files         721      721           
  Lines       52812    52811    -1     
  Branches     7669     7668    -1     
=======================================
  Hits        44791    44791           
+ Misses       5329     5328    -1     
  Partials     2692     2692           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit 6007445 Oct 29, 2025
14 of 16 checks passed
@david-livefront david-livefront deleted the clean-up-deprecations branch October 29, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants