Skip to content

PM-34115: bug: Consistent visual length of TOTP codes#6716

Merged
david-livefront merged 1 commit intomainfrom
PM-34115-totp-code-visual-length
Mar 25, 2026
Merged

PM-34115: bug: Consistent visual length of TOTP codes#6716
david-livefront merged 1 commit intomainfrom
PM-34115-totp-code-visual-length

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Mar 25, 2026

🎟️ Tracking

PM-34115

📔 Objective

This PR forces the UI to display TOTP codes in chunks of 3 characters to ensure that they have a consistent length.

📸 Screenshots

Before After

@david-livefront david-livefront requested a review from a team as a code owner March 25, 2026 16:30
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:bug Change Type - Bug labels Mar 25, 2026
@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.45%. Comparing base (41b7ca2) to head (958dd91).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6716      +/-   ##
==========================================
- Coverage   85.66%   85.45%   -0.21%     
==========================================
  Files         942      942              
  Lines       60349    60351       +2     
  Branches     8531     8531              
==========================================
- Hits        51696    51574     -122     
- Misses       5681     5812     +131     
+ Partials     2972     2965       -7     
Flag Coverage Δ
app-data 17.68% <0.00%> (-0.24%) ⬇️
app-ui-auth-tools 20.90% <0.00%> (-0.01%) ⬇️
app-ui-platform 15.63% <0.00%> (+0.04%) ⬆️
app-ui-vault 26.83% <100.00%> (+<0.01%) ⬆️
authenticator 6.55% <0.00%> (-0.01%) ⬇️
lib-core-network-bridge 4.25% <0.00%> (+<0.01%) ⬆️
lib-data-ui 0.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc3dafd42-731f-4990-9235-ad48f6cd769c

Great job! No new security vulnerabilities introduced in this pull request

Copy link
Contributor

@andrebispo5 andrebispo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💟

@david-livefront
Copy link
Collaborator Author

Thanks @andrebispo5

@david-livefront david-livefront added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit db0cf19 Mar 25, 2026
26 checks passed
@david-livefront david-livefront deleted the PM-34115-totp-code-visual-length branch March 25, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants