Refactored docs on feature flag consumption in code. #571
+40
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying contributing-docs with
|
| Latest commit: |
a2809f7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0819c028.contributing-docs.pages.dev |
| Branch Preview URL: | https://feature-flag-cache-override.contributing-docs.pages.dev |
|
Great job, no security vulnerabilities found in this Pull Request |
|
@vvolkgang do we have any documentation on how feature flags are cached on the mobile apps? I've added a section here that describes how this works on the TS clients, and I want to make sure I address mobile as well if there is any comparable logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Objective
The documentation on consumption of feature flags on clients was out of date. It described specific methods that needed to be used, and had been made obsolete by a refactor of the
ConfigServiceon web clients as well as the move to native mobile apps.Rather than describe code in the docs, I've removed that section and instead focused on describing how clients need to react to client caching of flag values, as well as how developers can override it locally. This was not documented previously.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes