[PM-18596] feat: Hide SSN Field by Default on Identity Screen #1380
+43
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
I'm a heavy user of Bitwarden and I think this could be a pretty useful feature. I haven't linked it to a specific issue or Jira ticket, but I noticed that while credit card numbers are hidden by default, the SSN field in identity items isn't. This change comes from my own experience using the app.
📔 Objective
I feel like the SSN field in identity should be hidden by default because its value is arguably even more sensitive than a password. It doesn't make much sense for it to be in plain text when other sensitive fields, like credit card numbers, are already protected.
I think there's still some work to be done to align it with Bitwarden's design principles. One area for example I'm still not 100% on is adding the proper eventType for the SSN toggle. Any feedback or pointers on that would be awesome.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes