Skip to content

[PM-27018] Add 22 supported languages and fix existing language codes in Password Manager and Authenticator #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 3, 2025
Merged

[PM-27018] Add 22 supported languages and fix existing language codes in Password Manager and Authenticator #2086

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dc745af
Add missing languages to both apps
vvolkgang Oct 30, 2025
576576a
Remove Esperanto :(
vvolkgang Oct 31, 2025
691944d
BWA - Fix Brazilian Portuguese
vvolkgang Oct 31, 2025
b5aa961
BWA - Fix Simplified Chinese and Traditional Chinese.
vvolkgang Oct 31, 2025
07da63e
Update unit tests count
vvolkgang Nov 3, 2025
8b3fad2
fix pt-pt
vvolkgang Nov 3, 2025
3c60635
Add comment explaining the languageOptions count
vvolkgang Nov 3, 2025
ad42365
Update supported localizations (CFBundleLocalizations) in Info.plist …
vvolkgang Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions AuthenticatorShared/Core/Platform/Models/Enum/LanguageOption.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,46 +23,67 @@ public enum LanguageOption: Equatable {
private static let languageCodes =
[
"af",
"ar",
"az",
"be",
"bg",
"bn",
"bs",
"ca",
"cs",
"cy",
"da",
"de",
"el",
"en",
"en-GB",
"eo",
"en-IN",
"es",
"et",
"eu",
"fa",
"fi",
"fil",
"fr",
"gl",
"he",
"hi",
"hr",
"hu",
"id",
"it",
"ja",
"ka",
"kn",
"ko",
"lt",
"lv",
"ml",
"mr",
"my",
"nb",
"ne",
"nl",
"nn-NO",
"or",
"pl",
"pt-BT",
"pt-PT",
"pt",
"pt-BR",
"ro",
"ru",
"si",
"sk",
"sl",
"sr",
"sv",
"ta",
"te",
"th",
"tr",
"uk",
"vi",
"zh-CN",
"zh-TW",
"zh-Hans",
"zh-Hant",
]

// MARK: Properties
Expand Down
2 changes: 1 addition & 1 deletion AuthenticatorShared/Core/Platform/Models/Enum/LanguageOptionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class LanguageOptionTests: BitwardenTestCase {
let allCases = LanguageOption.allCases
XCTAssertEqual(allCases.first, .default)
XCTAssertEqual(allCases[1], .custom(languageCode: "af"))
XCTAssertEqual(allCases.count, 42)
XCTAssertEqual(allCases.count, 63) // "default" + "en" + crowdin provided languages
}

/// `init` returns the correct values.
Expand Down
25 changes: 23 additions & 2 deletions BitwardenShared/Core/Platform/Models/Enum/LanguageOption.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,40 +23,61 @@ public enum LanguageOption: Equatable, Sendable {
private static let languageCodes =
[
"af",
"ar",
"az",
"be",
"bg",
"bn",
"bs",
"ca",
"cs",
"cy",
"da",
"de",
"el",
"en",
"en-GB",
"eo",
"en-IN",
"es",
"et",
"eu",
"fa",
"fi",
"fil",
"fr",
"gl",
"he",
"hi",
"hr",
"hu",
"id",
"it",
"ja",
"ka",
"kn",
"ko",
"lt",
"lv",
"ml",
"mr",
"my",
"nb",
"ne",
"nl",
"nn-NO",
"or",
"pl",
"pt",
"pt-BR",
"pt-PT",
"ro",
"ru",
"si",
"sk",
"sl",
"sr",
"sv",
"ta",
"te",
"th",
"tr",
"uk",
Expand Down
2 changes: 1 addition & 1 deletion BitwardenShared/Core/Platform/Models/Enum/LanguageOptionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class LanguageOptionTests: BitwardenTestCase {
let allCases = LanguageOption.allCases
XCTAssertEqual(allCases.first, .default)
XCTAssertEqual(allCases[1], .custom(languageCode: "af"))
XCTAssertEqual(allCases.count, 42)
XCTAssertEqual(allCases.count, 63) // "default" + "en" + crowdin provided languages
}

/// `init` returns the correct values.
Expand Down
Loading