Skip to content

Conversation

@vleague2
Copy link
Contributor

@vleague2 vleague2 commented Nov 21, 2025

🎟️ Tracking

CL-806

📔 Objective

Add a feature flag for some changes we are making to the way we manage users' focus on Angular router changes. We want to be able to flip it off without a release if we see issues, since it touches a large surface area and will be difficult to test.

Also I kept putting the wrong ticket number in branch names and commits, sorry, ignore those!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details10e82ae3-4a5c-496e-99f2-72f82b6f9532

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.99%. Comparing base (08ce693) to head (1a76d12).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6623      +/-   ##
==========================================
- Coverage   53.00%   52.99%   -0.01%     
==========================================
  Files        1909     1909              
  Lines       84828    84828              
  Branches     7634     7634              
==========================================
- Hits        44961    44958       -3     
- Misses      38115    38117       +2     
- Partials     1752     1753       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vleague2 vleague2 marked this pull request as ready for review November 21, 2025 17:15
@vleague2 vleague2 requested a review from willmartian November 21, 2025 17:15
@claude
Copy link
Contributor

claude bot commented Nov 21, 2025

Claude Code is working…

I'll analyze this and get back to you.

View job run

@vleague2 vleague2 merged commit 3559759 into main Nov 25, 2025
47 of 48 checks passed
@vleague2 vleague2 deleted the uif/cl-923/flag branch November 25, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants