Skip to content

Use proxy for github request and allow scheme in proxy host #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
taikuukaits wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use proxy for github request and allow scheme in proxy host #2

taikuukaits wants to merge 2 commits into from

Conversation

@taikuukaits
Copy link
Contributor

@taikuukaits taikuukaits commented Apr 6, 2018

Fixes two issues:

  1. Use a proxy if available to download the detect script from github. This code was moved from the detect powershell script up to the tfs script. Unfortunately we will now need to keep them in sync.
  2. When a scheme is provided in the host, the UriBuilder was failing to parse it. Now we treat host as a uri and let the builder's constructor parse it. This change also happened on the detect repository.

@taikuukaits taikuukaits mentioned this pull request Apr 6, 2018
Open
@kms254
Copy link

kms254 commented Apr 11, 2018

@taikuukaits Any update getting this PR through?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taikuukaits @kms254