Implement Optax-based LBFGS #749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated lbfgs to truncate history to reduce inverse hessian computation.
- Introduced a new test class to verify the functionality and convergence of the function. - Implemented a test method that checks the consistency of the history and convergence of the optimizer.
|
Feel free to replace the jaxopt lbfgs directly. |
|
closing this in favour of #783 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (draft) PR adds the Optax-based LBFGS optimiser. Relates to Blackjax-devs/blackjax #704.
There are a lot of repeated codes between
_minimize_lbfgsandoptax_lbfgs. I am also seeking feedback or tips on how to reduce the code repetitions.Minor changes:
Testing: