Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx: disable open_file_cache if media is on NFS #17251

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

leccelecce
Copy link
Contributor

Proposed change

This change disables nginx's open_file_cache if the /media/frigate/clips directory is detected to be an NFS mount.

#17118 (reply in thread)

Above comment covers the investigation into this in more details; TLDR = the creator of nginx says don't use open_file_cache with NFS mounts due to the filesystem not properly observing unix file semantics: https://trac.nginx.org/nginx/ticket/478

The nginx ticket is from 2014, but seeing as I see an issue without the fix, and it goes away with the fix, fair to assume it's still valid.

I have tested this locally in my devcontainer (non-NFS) and my test instance (NFSv4) and it seems to work fine. I don't observe any performance degradation browsing around the UI. Once betas start and a broader user-base is testing this, happy to look into any performance concerns.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • UI changes including text have used i18n keys and have been added to the en locale.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 314b842
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/67dac52f9eb8f80008aa9aa5
😎 Deploy Preview https://deploy-preview-17251--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@leccelecce leccelecce marked this pull request as ready for review March 19, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant