Better types for brands, tickets, macros, webhooks, articles #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Update types for:
This PR mostly adds typing using comments. To add
Brand
type I needed renameBrand
client toBrands
, but that rename affected only internal import, from external API nothing changed. We can do either that, or change brand type to something else if we wish to avoid this change.Related Issue(s)
Additional Information
Test Cases
Include any test cases or steps you took to test your changes. If you have added new functionality, please include relevant unit tests.
Documentation
Checklist