Skip to content

Better types for brands, tickets, macros, webhooks, articles #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KiraLT
Copy link

@KiraLT KiraLT commented May 12, 2025

Pull Request Description

Update types for:

  • Brand API types
  • Webhooks API types
  • Macros API types
  • Knowledge API articles and categories partial types
  • Ticket API via field, updated getComments type

This PR mostly adds typing using comments. To add Brand type I needed rename Brand client to Brands, but that rename affected only internal import, from external API nothing changed. We can do either that, or change brand type to something else if we wish to avoid this change.


Related Issue(s)

  • This PR fixes/closes issue #...
  • This is a new feature and does not have an associated issue.

Additional Information

  • This change is a breaking change (may require a major version update)
  • This change is a new feature (non-breaking change which adds functionality)
  • This change improves the code (e.g., refactoring, etc.)
  • This change includes dependency updates

Test Cases

Include any test cases or steps you took to test your changes. If you have added new functionality, please include relevant unit tests.


Documentation

  • I have updated the documentation accordingly.
  • No updates are required.

Checklist

  • I have read the CONTRIBUTING documentation.
  • My code follows the coding standards of this project.
  • All new and existing tests passed.

@KiraLT KiraLT changed the title Better types for brands, tickets, macros, webhooks and Better types for brands, tickets, macros, webhooks, articles May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant