Skip to content

This commit addresses the problem of not being able to upload the sam…#428

Open
maikdiepenbroek wants to merge 2 commits into
bleenco:masterfrom
maikdiepenbroek:master
Open

This commit addresses the problem of not being able to upload the sam…#428
maikdiepenbroek wants to merge 2 commits into
bleenco:masterfrom
maikdiepenbroek:master

Conversation

@maikdiepenbroek
Copy link
Copy Markdown

…e file twice.

Since the value property of the file component does not change, the change event does not fire preventing the user from starting the upload.

By adding a click handler on the input, the value is set to an empty string, causing the 'bug' to not happen.

…e file twice.

Since the value property of the file component does not change, the change event does not fire preventing the user from starting the upload.

By adding a click handler on the input, the value is set to an empty string, causing the 'bug' to not happen.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 19, 2018

CLA assistant check
All committers have signed the CLA.

@maikdiepenbroek
Copy link
Copy Markdown
Author

Could i get some feedback on this ?

@fireappsAdmin
Copy link
Copy Markdown

What is the status on this? I am also still having this issue. I don't know enough about your code to provide a review.

@maikdiepenbroek
Copy link
Copy Markdown
Author

Not much progress, i haven't got any response unfortunately

@maximelafarie
Copy link
Copy Markdown

What's the status of this PR? It's a really important fix! Please do smth.

Copy link
Copy Markdown
Contributor

@osahner osahner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor formatting issue. missing space if (

@osahner
Copy link
Copy Markdown
Contributor

osahner commented Oct 25, 2019

Please merge. The workaround for angular 8 is:

<input #fileInput type="file" ngFileSelect ...
  @ViewChild('fileInput', { static: false })
  fileInput: ElementRef;

  ngAfterViewInit() {
    // https://github.com/bleenco/ngx-uploader/issues/474
    this.fileInput.nativeElement.onclick = function() {
      this.value = null;
    };
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants