Conversation
Targets under a `targets:` list are planned each and converge on their own, so they are free to hold different schemas and usually do. The plan comment named that divergence but still rendered only the reviewed plan's DDL, which left an operator authorizing work the comment never showed them. Each distinct plan now renders under the members that would run it. The reviewed plan's block stays open, the rest collapse behind a consent line saying the apply runs them too, and a member group already at the desired schema is named rather than hidden. The summary line counts the rollout instead of the reviewed plan alone. A primary already at the desired schema no longer short-circuits the comment to "no schema changes detected" when its siblings still have work to apply, which upholds UX-3: the comment describes the apply an operator would authorize, not one member of it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
aparajon
marked this pull request as ready for review
September 17, 2026 20:51
aparajon
requested review from
JashLal,
Kiran01bm,
eeSeeGee,
jayjanssen,
jemiahw and
morgo
as code owners
September 17, 2026 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets under a
targets:list are planned each and converge on their own, sothey are free to hold different schemas and usually do. The plan comment already
named that divergence, but it still rendered only the reviewed plan's DDL. An
operator was being asked to authorize work the comment never showed them.
Each distinct plan now renders under the members that would run it. The reviewed
plan stays open, the rest collapse behind a line saying the apply runs them too,
and a group already at the desired schema is named rather than hidden. The
summary line counts the rollout rather than the reviewed plan alone.
A primary already at the desired schema also no longer short-circuits the whole
comment to "No schema changes detected" while its siblings still have work.
In the example below
primary/testapp_1is the reviewed target and altersusers,primary/testapp_2plans the same change, andprimary/testapp_3plansthat alter plus an index.
This upholds RV-3: the consent an operator gives is specific to what will
run, and what will run is every target's plan, not one member's.
Targets converging: before
Schema Change Plan — Production
Database:
testapp| Type:MySQL| Schema Name:testappRequested by @jackjackbits at 2026-01-01 00:00:00 UTC · planned from
abcdef1✅ Planned separately for all 3 targets (
primary/testapp_1,primary/testapp_2,primary/testapp_3) — 2 need this change, 1 is already at this schema.📋 Plan: 1 table to alter
Targets converging: after
Schema Change Plan — Production
Database:
testapp| Type:MySQL| Schema Name:testappRequested by @jackjackbits at 2026-01-01 00:00:00 UTC · planned from
abcdef1✅ Planned separately for all 3 targets (
primary/testapp_1,primary/testapp_2,primary/testapp_3) — 2 need this change, 1 is already at this schema.primary/testapp_1(primary),primary/testapp_3— 1 DDL statementprimary/testapp_2— already at this schema, nothing to apply.📋 Plan: 1 DDL statement on 2 of 3 targets
Targets diverging: before
Schema Change Plan — Production
Database:
testapp| Type:MySQL| Schema Name:testappRequested by @jackjackbits at 2026-01-01 00:00:00 UTC · planned from
abcdef1✅ Planned separately for all 3 targets (
primary/testapp_1,primary/testapp_2,primary/testapp_3) — 2 distinct plans. Each target applies its own.📋 Plan: 1 table to alter
Targets diverging: after
Schema Change Plan — Production
Database:
testapp| Type:MySQL| Schema Name:testappRequested by @jackjackbits at 2026-01-01 00:00:00 UTC · planned from
abcdef1✅ Planned separately for all 3 targets (
primary/testapp_1,primary/testapp_2,primary/testapp_3) — 2 distinct plans. Each target applies its own.`primary/testapp_1` (primary), `primary/testapp_2` — 1 DDL statement
`primary/testapp_3` — 2 DDL statements
📋 Plan: 2 distinct plans on 3 targets
Opened by Claude (Claude Opus 5).