Skip to content

remove spdebug from cdb2api client #6034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
emelialei88 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

remove spdebug from cdb2api client #6034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 3 additions & 33 deletions cdb2api/cdb2api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4317,41 +4317,11 @@ static int cdb2_read_record(cdb2_hndl_tp *hndl, uint8_t **buf, int *len, int *ty
if (hdr.type == RESPONSE_HEADER__SQL_RESPONSE_TRACE) {
CDB2SQLRESPONSE *response =
cdb2__sqlresponse__unpack(NULL, hdr.length, *buf);
if (response->response_type == RESPONSE_TYPE__SP_TRACE) {
if (response && response->response_type == RESPONSE_TYPE__SP_TRACE) {
fprintf(stdout, "%s\n", response->info_string);
}
if (response) {
cdb2__sqlresponse__free_unpacked(response, NULL);
} else {
fprintf(stdout, "%s", response->info_string);
cdb2__sqlresponse__free_unpacked(response, NULL);
char cmd[250];
if (fgets(cmd, 250, stdin) == NULL ||
strncasecmp(cmd, "quit", 4) == 0) {
/* don't exit program, just quit sp in the middle
finish should be used to quit debugger and run sp till end */
rc = -1;
goto after_callback;
}
CDB2QUERY query = CDB2__QUERY__INIT;
query.spcmd = cmd;
int loc_len = cdb2__query__get_packed_size(&query);
unsigned char *locbuf = malloc(loc_len + 1);

cdb2__query__pack(&query, locbuf);

struct newsqlheader hdr = {.type =
ntohl(CDB2_REQUEST_TYPE__CDB2QUERY),
.compression = ntohl(0),
.length = ntohl(loc_len)};

cdb2buf_write((char *)&hdr, sizeof(hdr), hndl->sb);
cdb2buf_write((char *)locbuf, loc_len, hndl->sb);

int rc = cdb2buf_flush(hndl->sb);
free(locbuf);
if (rc < 0) {
rc = -1;
goto after_callback;
}
}
debugprint("- going to retry\n");
if (hndl->retry_clbk) {
Expand Down
Loading