fix: add structural loading fallback to page speed monitor status lab… - #3789
Open
PATRIKA-123 wants to merge 1 commit into
Open
fix: add structural loading fallback to page speed monitor status lab…#3789PATRIKA-123 wants to merge 1 commit into
PATRIKA-123 wants to merge 1 commit into
Conversation
PATRIKA-123
requested review from
Br0wnHammer,
ajhollid and
karenvicent
as code owners
July 19, 2026 18:00
ajhollid
requested changes
Jul 20, 2026
ajhollid
left a comment
ajhollid
left a comment
Collaborator
There was a problem hiding this comment.
This PR is just the addition of a comment?
Contributor
|
and import of useTheme |
Collaborator
That was already imported? What is the purpose of this PR? The description states it adds a fallback string, am I missing something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added a structural loading fallback string (
"initializing") to thePageSpeedMonitorsTablestatus renderer. This prevents the UI component from breaking or hanging in an undefined state if a monitor's backend status returns empty or null during initial load metrics fetching.Fixes #3772
Checklist