fix: restore status page custom domains - #3812
Conversation
|
Custom-domain verification is complete. I confirmed that the published status page resolves correctly when CLIENT_CONFIG_CLIENT_HOST is not configured. The PR description and checklist have been updated, and this is ready for maintainer review. |
|
The
The failure mode is a blank page rather than an error. There's also no way to opt out once this merges: Would it work to gate the status-page routes on the resolve actually returning a status page, and fall back to the normal route table when it doesn't? That keeps #3811 fixed for genuine custom domains, and turns the unknown-host case into the normal app instead of a blank screen. Context: we host Checkmate for users at PikaPods, where each instance keeps its default |
Describe your changes
Restores custom-domain status page routing when
CLIENT_CONFIG_CLIENT_HOSTis not explicitly configured.The runtime-config migration omitted
clientHostfrom/config.jsby default. On a custom domain, the client therefore fell back to that domain's ownwindow.location.origin, treated it as the main Checkmate host, and rendered the login routes instead of resolving the published status page.This change:
CLIENT_HOSTthrough the generated client configCLIENT_CONFIG_CLIENT_HOSTas the explicit higher-priority overrideWrite your issue number after "Fixes "
Fixes #3811
Verification
CLIENT_CONFIG_CLIENT_HOSTis not configured.npm test -- --runTestsByPath test/unit/services/settingsService.test.ts --runInBand --coverage=false— 13 tests passednpm test -- --runInBand --coverage=false— 74 suites, 1,328 tests passednpm run typeCheckinservernpm run lintinservernpm run buildinserverandclientnpm run format-checkinserverandclientgit diff --checkChecklist