Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export default tseslint.config(
'unicorn/prevent-abbreviations': 'off',

// typescript-eslint rules:
'@typescript-eslint/consistent-type-imports': 'error',
'@typescript-eslint/no-unnecessary-condition': 'off', // Dozens of places where the rule's `meta` property needs optional chaining get flagged by this.
'@typescript-eslint/no-unused-vars': 'off',
'@typescript-eslint/prefer-readonly': 'error',
Expand Down
8 changes: 2 additions & 6 deletions lib/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,8 @@ import { OPTION_DEFAULTS } from './options.js';
import { cosmiconfig } from 'cosmiconfig';
import Ajv from 'ajv';
import merge from 'deepmerge';
import {
COLUMN_TYPE,
NOTICE_TYPE,
GenerateOptions,
OPTION_TYPE,
} from './types.js';
import type { GenerateOptions } from './types.js';
import { COLUMN_TYPE, NOTICE_TYPE, OPTION_TYPE } from './types.js';
import { getCurrentPackageVersion } from './package-json.js';
import { boolean, isBooleanable } from './boolean.js';
import { CONFIG_FORMATS } from './config-format.js';
Expand Down
3 changes: 2 additions & 1 deletion lib/config-list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import {
} from './comment-markers.js';
import { markdownTable } from 'markdown-table';
import type { ConfigsToRules, ConfigEmojis, Plugin, Config } from './types.js';
import { ConfigFormat, configNameToDisplay } from './config-format.js';
import type { ConfigFormat } from './config-format.js';
import { configNameToDisplay } from './config-format.js';
import { getEndOfLine, sanitizeMarkdownTable } from './string.js';

const EOL = getEndOfLine();
Expand Down
4 changes: 2 additions & 2 deletions lib/generator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ import {
import { resolveConfigsToRules } from './plugin-config-resolution.js';
import { OPTION_DEFAULTS } from './options.js';
import { diff } from 'jest-diff';
import type { GenerateOptions } from './types.js';
import { OPTION_TYPE, RuleModule } from './types.js';
import type { GenerateOptions, RuleModule } from './types.js';
import { OPTION_TYPE } from './types.js';
import { replaceRulePlaceholder } from './rule-link.js';
import { updateRuleOptionsList } from './rule-options-list.js';
import { mkdir, readFile, writeFile } from 'node:fs/promises';
Expand Down
4 changes: 2 additions & 2 deletions lib/options.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { join } from 'node:path';
import { ConfigFormat } from './config-format.js';
import { RuleDocTitleFormat } from './rule-doc-title-format.js';
import type { ConfigFormat } from './config-format.js';
import type { RuleDocTitleFormat } from './rule-doc-title-format.js';
import { COLUMN_TYPE, NOTICE_TYPE, OPTION_TYPE } from './types.js';

export const COLUMN_TYPE_DEFAULT_PRESENCE_AND_ORDERING: {
Expand Down
5 changes: 2 additions & 3 deletions lib/plugin-config-resolution.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import { existsSync } from 'node:fs';
import { importAbs } from './import.js';
import type { Plugin, Config, Rules, ConfigsToRules } from './types.js';
import { TSESLint } from '@typescript-eslint/utils';
import type { TSESLint } from '@typescript-eslint/utils';

import {
import type {
ClassicConfig,
FlatConfig,
// eslint-disable-next-line import/extensions -- false positive
} from '@typescript-eslint/utils/dist/ts-eslint';

/**
Expand Down
13 changes: 7 additions & 6 deletions lib/rule-doc-notices.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,18 @@ import {
EMOJI_OPTIONS,
} from './emojis.js';
import { findConfigEmoji, getConfigsForRule } from './plugin-configs.js';
import {
import type {
RuleModule,
Plugin,
ConfigsToRules,
ConfigEmojis,
SEVERITY_TYPE,
NOTICE_TYPE,
UrlRuleDocFunction,
PathRuleDocFunction,
} from './types.js';
import { RULE_TYPE, RULE_TYPE_MESSAGES_NOTICES } from './rule-type.js';
import { RuleDocTitleFormat } from './rule-doc-title-format.js';
import { SEVERITY_TYPE, NOTICE_TYPE } from './types.js';
import type { RULE_TYPE } from './rule-type.js';
import { RULE_TYPE_MESSAGES_NOTICES } from './rule-type.js';
import type { RuleDocTitleFormat } from './rule-doc-title-format.js';
import { hasOptions } from './rule-options.js';
import { getLinkToRule, replaceRulePlaceholder } from './rule-link.js';
import {
Expand All @@ -28,7 +28,8 @@ import {
addTrailingPeriod,
getEndOfLine,
} from './string.js';
import { ConfigFormat, configNameToDisplay } from './config-format.js';
import type { ConfigFormat } from './config-format.js';
import { configNameToDisplay } from './config-format.js';

const EOL = getEndOfLine();

Expand Down
4 changes: 2 additions & 2 deletions lib/rule-link.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { join, sep, relative, dirname } from 'node:path';
import {
import type {
PathRuleDocFunction,
Plugin,
RULE_SOURCE,
UrlRuleDocFunction,
} from './types.js';
import { RULE_SOURCE } from './types.js';
import { getPluginRoot } from './package-json.js';

export function replaceRulePlaceholder(
Expand Down
12 changes: 4 additions & 8 deletions lib/rule-list-legend.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,11 @@ import {
EMOJI_CONFIG_FROM_SEVERITY,
} from './emojis.js';
import { findConfigEmoji, getConfigsThatSetARule } from './plugin-configs.js';
import {
COLUMN_TYPE,
ConfigEmojis,
Plugin,
ConfigsToRules,
SEVERITY_TYPE,
} from './types.js';
import type { ConfigEmojis, Plugin, ConfigsToRules } from './types.js';
import { COLUMN_TYPE, SEVERITY_TYPE } from './types.js';
import { RULE_TYPE_MESSAGES_LEGEND, RULE_TYPES } from './rule-type.js';
import { ConfigFormat, configNameToDisplay } from './config-format.js';
import type { ConfigFormat } from './config-format.js';
import { configNameToDisplay } from './config-format.js';
import { getEndOfLine } from './string.js';

const EOL = getEndOfLine();
Expand Down
13 changes: 5 additions & 8 deletions lib/rule-list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,17 @@ import { findSectionHeader, findFinalHeaderLevel } from './markdown.js';
import { getPluginRoot } from './package-json.js';
import { generateLegend } from './rule-list-legend.js';
import { relative } from 'node:path';
import {
COLUMN_TYPE,
RuleListSplitFunction,
RuleModule,
SEVERITY_TYPE,
UrlRuleDocFunction,
} from './types.js';
import { COLUMN_TYPE, SEVERITY_TYPE } from './types.js';
import { markdownTable } from 'markdown-table';
import type {
Plugin,
ConfigsToRules,
ConfigEmojis,
RuleNamesAndRules,
PathRuleDocFunction,
RuleListSplitFunction,
RuleModule,
UrlRuleDocFunction,
} from './types.js';
import { EMOJIS_TYPE } from './rule-type.js';
import { hasOptions } from './rule-options.js';
Expand All @@ -42,7 +39,7 @@ import { noCase } from 'change-case';
import { getProperty } from 'dot-prop';
import { boolean, isBooleanable } from './boolean.js';
import Ajv from 'ajv';
import { ConfigFormat } from './config-format.js';
import type { ConfigFormat } from './config-format.js';

function isBooleanableTrue(value: unknown): boolean {
return isBooleanable(value) && boolean(value);
Expand Down
3 changes: 2 additions & 1 deletion lib/rule-options-list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import {
} from './comment-markers.js';
import { markdownTable } from 'markdown-table';
import type { RuleModule } from './types.js';
import { RuleOption, getAllNamedOptions } from './rule-options.js';
import type { RuleOption } from './rule-options.js';
import { getAllNamedOptions } from './rule-options.js';
import { getEndOfLine, sanitizeMarkdownTable } from './string.js';

const EOL = getEndOfLine();
Expand Down
2 changes: 1 addition & 1 deletion lib/types.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { RuleDocTitleFormat } from './rule-doc-title-format.js';
import type { TSESLint } from '@typescript-eslint/utils';
import { ConfigFormat } from './config-format.js';
import type { ConfigFormat } from './config-format.js';

// Standard ESLint types.

Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"node",
"jest"
],
"verbatimModuleSyntax": true
},
"include": [
"bin/**/*",
Expand Down
Loading