[Feature/#82] 순서 변경 및 길이 편집 로직 보완 및 UI연결 #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
051198Hz
requested review from
LURKS02,
around-forest and
jungseokyoung-cloud
and removed request for
around-forest and
jungseokyoung-cloud
4 tasks
jungseokyoung-cloud
approved these changes
Dec 5, 2024
Domain/UseCase/VideoUseCase.swift
Outdated
| let video = editingVideos.remove(at: oldIndex) | ||
| editingVideos.insert(video, at: index) | ||
|
|
||
| let newVideos = editingVideos.enumerated().map { (index, video) in |
There was a problem hiding this comment.
P2: 굳이 새로운 변수를 할당할 필요가 없어보입니다
There was a problem hiding this comment.
이거는 리스트의 인덱스 기반으로 비디오 인덱스를 다시 할당하고있는 코드여서 필요할 것 같슴니다 ㅠㅜ
| await timeLineItem.append(item) | ||
| } | ||
| owner.output.send(.timelineItemsDidChanged(items: newTimelineItems)) | ||
| // let newTimelineItems = await orderdVideos.asyncCompactMap { video in |
There was a problem hiding this comment.
P2: 주석 제거 하셔야 할꺼 같습니다!
around-forest
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
✅ 완료 및 수정 내역
🛠️ 테스트 방법
📝 리뷰 노트
장원영님 마무리 부탁드리겠슴니다
📱 스크린샷(선택)
2024-12-05.10.48.45.mov
2024-12-05.10.52.10.mov