Skip to content

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Oct 7, 2025

@pdimov
Copy link
Member

pdimov commented Oct 7, 2025

Looks like boostorg/pfr#224 hasn't been merged.

Do you look for cmake_minimum_required in test/CMakeLists.txt? If so, maybe that should be added to PFR's test/CML, instead of conditioning the tests.

@Flamefire
Copy link
Contributor Author

Flamefire commented Oct 7, 2025

Looks like boostorg/pfr#224 hasn't been merged.

I added that when the CI failed and a checkbox to the description here.

Do you look for cmake_minimum_required in test/CMakeLists.txt? If so, maybe that should be added to PFR's test/CML, instead of conditioning the tests.

Not yet. Usually cmake_minimum_required should be done at the top-level CML anyway.
As for PFR: only a subset of the tests require C++20. In B2 those won't be build in C++17 mode or below. So that change mirrors that, building as much as possible. I don't see a need to error out when building the tests with an older CMake version

@pdimov
Copy link
Member

pdimov commented Oct 10, 2025

Please retarget against cmake_versions.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants