[BOOST-5262] feat(sdk): TransparentBudget implementation #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An owner of a boost deployed from a Transparent budget can clawback the funds of an active boost, but they must call the interface directly. It is possible to allow for EIP-712 signed clawbacks submitted by another address, but it's probably more important to get back to automations asap.
This library is for testing only and has no direct impact on deployed source code.
🦋 Changeset detectedLatest commit: 698846c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
1 similar comment
…st-on-a-transparent-budget
mmackz
reviewed
Mar 10, 2025
test/src/helpers.ts
Outdated
| export function fundTransparentBudget( | ||
| options: DeployableTestOptions, | ||
| fixtures: Fixtures, | ||
| budget?: ManagedBudget, |
There was a problem hiding this comment.
Suggested change
| budget?: ManagedBudget, | |
| budget?: TransparentBudget, |
mmackz
reviewed
Mar 10, 2025
test/src/helpers.ts
Outdated
| // }); | ||
|
|
||
| return { budget, erc20, erc1155, points } as BudgetFixtures & { | ||
| budget: ManagedBudget; |
There was a problem hiding this comment.
Suggested change
| budget: ManagedBudget; | |
| budget: TransparentBudget; |
|
Left some suggested changes to fix the type errors. |
1 similar comment
…st-on-a-transparent-budget
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@boostxyz/sdk": minor | |||
There was a problem hiding this comment.
do we also want to open up a changeset against evm?
There was a problem hiding this comment.
we don't publish evm so it doesn't really matter, also this pr doesn't alter contract logic
mmackz
reviewed
Mar 11, 2025
mmackz
reviewed
Mar 11, 2025
| ) { | ||
| return async function freshTransparentBudget() { | ||
| const budget = new fixtures.bases.TransparentBudget(options); | ||
| await budget.deploy(); |
jonathandiep
approved these changes
Mar 11, 2025
sammccord
deleted the
sam/boost-5262-sdk-work-to-support-createboost-on-a-transparent-budget
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
basic transparent budget implementation
additional
BoostCore.createBoostmethods to support new creation methodtsdoc, basic boost creation tests
still needs mintlify documentation
💔 Thank you!