Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lints: Add recursive lint traversal infrastructure #1218

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

cgwalters
Copy link
Collaborator

@cgwalters cgwalters commented Mar 21, 2025

Right now the utf8 lint does a tree walk. I want
to add more, but it'd be good to avoid walking
the whole filesystem multiple times.

In paticular I wanted to add a check for ostree.usermeta
should never be present.

Signed-off-by: Colin Walters [email protected]

@cgwalters
Copy link
Collaborator Author

Thought I could knock out a quick check for user.ostreemeta being present but then I realized we already had a full recursive traversal of the tree in the utf8 check, and wanted to avoid duplicating that and also avoid walking everything twice, which increases complexity. Stashing this here for now.

@cgwalters cgwalters force-pushed the lint-global-traversal-prep branch 4 times, most recently from f0db54f to 78b0484 Compare April 8, 2025 17:03
@cgwalters cgwalters marked this pull request as ready for review April 8, 2025 17:03
@cgwalters cgwalters requested a review from Copilot April 8, 2025 17:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Right now the `utf8` lint does a tree walk. I want
to add more, but it'd be good to avoid walking
the whole filesystem multiple times.

In paticular I wanted to add a check for `ostree.usermeta`
should never be present.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters force-pushed the lint-global-traversal-prep branch from 78b0484 to 67283ac Compare April 8, 2025 17:23
@cgwalters cgwalters changed the title WIP: Refactor recursive lint traversal lints: Add recursive lint traversal infrastructure Apr 8, 2025
@cgwalters cgwalters requested a review from ckyrouac April 8, 2025 18:57
@ckyrouac ckyrouac merged commit 3dbff8c into bootc-dev:main Apr 9, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants