wip test #1837
wip test #1837
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request appears to be for exploring the testing framework, as indicated by the title and description. It includes several temporary changes, such as hardcoded test filters, debug print statements, commented-out functionality, and a new example test file. These changes should be reverted before merging. I've left specific comments on each of these points. The typo fix in docs/src/host-v1.schema.json is a good correction.
| if stem != "testing-ex" { | ||
| println!("SKIPPING: {stem}"); | ||
| continue | ||
| } |
There was a problem hiding this comment.
This block of code hardcodes the test execution to only run for testing-ex. This appears to be for debugging and should be removed before merging to allow all tests to be processed.
| fn update_generated(sh: &Shell) -> Result<()> { | ||
| // Update man pages (create new templates + sync options) | ||
| man::update_manpages(sh)?; | ||
| // man::update_manpages(sh)?; |
There was a problem hiding this comment.
This function call appears to be commented out for testing. Please re-enable it before merging to ensure man pages are updated.
| // man::update_manpages(sh)?; | |
| man::update_manpages(sh)?; |
|
|
||
| // Update JSON schemas | ||
| update_json_schemas(sh)?; | ||
| // update_json_schemas(sh)?; |
There was a problem hiding this comment.
This function call appears to be commented out for testing. Please re-enable it before merging to ensure JSON schemas are updated.
| // update_json_schemas(sh)?; | |
| update_json_schemas(sh)?; |
|
|
||
| let test_command = format!("{} {}", extension, relative_path.display()); | ||
|
|
||
| println!("test_command: {test_command}"); |
There was a problem hiding this comment.
This println! statement appears to be for debugging. Please remove it before merging.
| //! by the user - add commands here which otherwise might | ||
| //! end up as a lot of nontrivial bash code. | ||
| #![allow(dead_code)] |
There was a problem hiding this comment.
The crate-level #![allow(dead_code)] should be removed. While useful during development, it can hide real issues with unused code. If specific warnings need to be suppressed, it's better to apply the attribute to a more granular scope.
| **--all** | ||
|
|
||
| Print all configuration | ||
|
|
There was a problem hiding this comment.
This content has been added inside a block that appears to be auto-generated (<!-- BEGIN GENERATED OPTIONS --> ... <!-- END GENERATED OPTIONS -->). Manual edits here will likely be overwritten. If this option needs to be documented, the change should be made in the generation logic instead.
| # number: 450 | ||
| # tmt: | ||
| # summary: Some random test | ||
| # duration: 5m | ||
| # | ||
| # Verify that something works | ||
|
|
||
| def main[] { | ||
| echo "The test has passed" | ||
| } |
There was a problem hiding this comment.
This appears to be a temporary test file created for experimentation. It should be removed before this pull request is merged to avoid adding unnecessary test code to the repository.
1 participant
Figuring out how testing framework works