tests: Remove composefs-bcvk test infrastructure #1848
Conversation
The composefs-bcvk tests were a separate test path that ran integration tests directly via bcvk. This functionality is now covered by the tmt-based testing framework, so remove the redundant infrastructure. Signed-off-by: Colin Walters <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the redundant composefs-bcvk test infrastructure, which is now covered by the tmt-based testing framework. The changes are straightforward and correctly remove the old test path from the Justfile and the tests-integration crate. The implementation file and corresponding command-line interface logic are cleanly removed. I have one suggestion to complete the cleanup by removing a now-unused dependency.
| use cap_std_ext::cap_std::{self, fs::Dir}; | ||
| use clap::Parser; | ||
|
|
||
| mod composefs_bcvk; |
There was a problem hiding this comment.
With the removal of the composefs_bcvk module, the bootc-kernel-cmdline dependency appears to be unused within this crate. This dependency was used to parse kernel command line arguments, a functionality specific to the removed tests. To maintain a clean dependency tree, it should be removed from crates/tests-integration/Cargo.toml.
|
The fedora rawhide failure should be related with rawhide change https://fedoraproject.org/wiki/Changes/BootLoaderUpdatesPhase1. We have discussion in slack. |
3 participants
The composefs-bcvk tests were a separate test path that ran integration tests directly via bcvk. This functionality is now covered by the tmt-based testing framework, so remove the redundant infrastructure.