Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade selenium #745

Merged
merged 11 commits into from
Mar 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .yarnrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# yarn lockfile v1


lastUpdateCheck 1729300363924
lastUpdateCheck 1741731093687
5 changes: 2 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@ eval File.read(gems), binding, gems # rubocop: disable Security/Eval

require "#{__dir__}/lib/bootstrap_form/version"

gem "rails", BootstrapForm::REQUIRED_RAILS_VERSION
gem "sprockets-rails", require: "sprockets/railtie"

gem "bigdecimal" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0")
gem "drb" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0")
gem "mutex_m" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0")
gem "rails", BootstrapForm::REQUIRED_RAILS_VERSION
gem "sprockets-rails", require: "sprockets/railtie"
gem "sqlite3", "~> 1.4"
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,7 @@ will be rendered as:
</div>
</div>
</trix-toolbar>
<trix-editor aria-label="Life story" class="trix-content form-control" contenteditable="" data-blob-url-template="http://shell:3001/rails/active_storage/blobs/redirect/:signed_id/:filename" data-direct-upload-url="http://shell:3001/rails/active_storage/direct_uploads" id="user_life_story" input="user_life_story_trix_input_user" role="textbox" toolbar="trix-toolbar-1" trix-id="1">
<trix-editor aria-label="Life story" class="trix-content form-control" contenteditable="" data-blob-url-template="http://test.host/rails/active_storage/blobs/redirect/:signed_id/:filename" data-direct-upload-url="http://test.host/rails/active_storage/direct_uploads" id="user_life_story" input="user_life_story_trix_input_user" role="textbox" toolbar="trix-toolbar-1" trix-id="1">
</trix-editor>
</div>
```
Expand Down
5 changes: 3 additions & 2 deletions compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ services:
command: /bin/bash

selenium:
# Try removing headless=old option when upgrading the version.
image: selenium/standalone-chrome:129.0
image: selenium/standalone-chrome:133.0
shm_size: 2gb
logging:
driver: none
stdin_open: true
Expand All @@ -32,3 +32,4 @@ services:
ports:
- '4444:4444'
- '5900:5900'
- '7900:7900'
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified demo/doc/screenshots/bootstrap/index/00_horizontal_form.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/index/02_inline_form.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/index/04_floating_labels.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/00_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/01_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/02_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/03_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/04_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/05_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/06_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/07_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/08_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/09_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/10_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/11_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/12_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/13_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/14_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/doc/screenshots/bootstrap/readme/15_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/16_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/17_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/18_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/19_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/20_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/21_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/22_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/23_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/24_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/25_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/26_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/27_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/28_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/29_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/30_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/31_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/32_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/33_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/34_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/35_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/36_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/37_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/38_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/40_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/41_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/42_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/43_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/44_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/45_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/46_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/47_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/48_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/49_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/50_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/51_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/52_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/53_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/54_example.png
Binary file modified demo/doc/screenshots/bootstrap/readme/55_example.png
6 changes: 3 additions & 3 deletions demo/test/application_system_test_case.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ def remote_selenium? = @remote_selenium ||= ENV["SELENIUM_HOST"].present? || ENV
{}
end

driven_by :selenium, using: :headless_chrome, screen_size: [960, 720], options: options do |capabilities|
# Debugging tip: Change to `chrome` (not headless) and then browse to:
# http://localhost:7900/?autoconnect=1&resize=scale&password=secret. You can watch the fun there.
driven_by :selenium, using: :headless_chrome, screen_size: [960, 800], options: options do |capabilities|
capabilities.add_argument("force-device-scale-factor=1")
capabilities.add_argument("lang=#{ENV.fetch('LANG', 'en_CA')}")
# Needed for Selenium 129. Presumably remove at some point.
capabilities.add_argument("--headless=old")
end

if remote_selenium?
Expand Down
2 changes: 1 addition & 1 deletion demo/test/system/bootstrap_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class BootstrapTest < ApplicationSystemTestCase
#{html}
MD
end
augmented_readme.gsub!(/127.0.0.1:\d+/, "test.host")
augmented_readme.gsub!(/(127.0.0.1:\d+|shell:3001)/, "test.host")
File.write(File.expand_path("../../../README.md", __dir__), augmented_readme)
end

Expand Down