Expose --xmp-sidecar flag via config - #946
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
…onal The log summary line was nested inside an unrelated if-block during initial implementation, meaning it would only ever print when keep_icloud_recent_only was enabled instead of unconditionally, like every other flag-state summary line in this block. Co-Authored-By: Claude <noreply@anthropic.com>
Existing users' config files predate this variable and won't contain it
until the config-scaffolding task lands. Without a default, the bare
variable reference expands to empty string under this script's no-nounset
convention, and [ "" != "false" ] is true — silently turning on XMP
sidecar generation for every existing user the moment this commit ships,
with no opt-in. Use the ${var:-false} idiom already established elsewhere
in this file (icloud_china, single_pass, auth_domain) so this commit is
safe to deploy standalone, independent of scaffolding sequencing.
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
|
Been running this and it works great — thanks for picking it up. With One heads-up in case it helps: icloudpd itself crashes if |
Picks up #775.
Changes
This PR exposes
icloud_photos_downloader's--xmp-sidecarflag as a new config variable:xmp_sidecar. The default setting isfalse.A sidecar file will look something like this:
Behavior
Retroactive backfill
If files are already downloaded while the flag is
false, then it is later turned totrue,.xmpsidecar files will be downloaded for all files already in the library. Critically, this does not re-download assets already downloaded; just the sidecars.Live Photos
While Live Photos already have two files downloaded for each (
.HEIC+.MOV), only one.xmpsidecar is downloaded for one Live Photo. The sidecar counts for both files.Deletion
When assets are deleted from iCloud, icloudpd will sync those deletions down to the sidecar as well, leaving no orphaned
.xmpfiles.Let me know if any changes are desired here.