enable partial/incremental ChunkIndex cache updates #8541
+111
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ChunkIndex: implement system flags - ChunkIndex: F_NEW flag as 1st system flag for newly added chunks - incrementally write only NEW chunks to repo/cache/chunks.* - merge all chunks.* when loading the ChunkIndex from the repo Also: the cached ChunkIndex only has the chunk IDs. All values are just dummies. The ChunkIndexEntry value can be used to set flags and track size, but we intentionally do not persist flags and size to the cache. The size information gets set when borg loads the files cache and "compresses" the chunks lists in the files cache entries. After that, all chunks referenced by the files cache will have a valid size as long as the ChunkIndex is in memory. This is needed so that "uncompress" can work.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8541 +/- ##
==========================================
- Coverage 81.80% 81.79% -0.02%
==========================================
Files 74 74
Lines 13281 13290 +9
Branches 1955 1956 +1
==========================================
+ Hits 10864 10870 +6
- Misses 1754 1756 +2
- Partials 663 664 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8503.
Fixes #8538.