Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickfix : borg exits when assertions are disabled with Python optimizations #8685

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

120EE0980
Copy link

Quick-workaround for #8649

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.45%. Comparing base (15ec434) to head (7cf8316).
Report is 10 commits behind head on 1.4-maint.

Files with missing lines Patch % Lines
src/borg/archiver.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           1.4-maint    #8685      +/-   ##
=============================================
- Coverage      82.70%   82.45%   -0.25%     
=============================================
  Files             38       38              
  Lines          11117    11123       +6     
  Branches        1725     1725              
=============================================
- Hits            9194     9172      -22     
- Misses          1366     1390      +24     
- Partials         557      561       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@120EE0980
Copy link
Author

Should I add tests for this fix?(Is that why Codecov is showing missing coverage )

@ThomasWaldmann
Copy link
Member

No, I don't think we need a test for this.

@ThomasWaldmann ThomasWaldmann merged commit d892bca into borgbackup:1.4-maint Mar 10, 2025
10 of 12 checks passed
@ThomasWaldmann
Copy link
Member

Thanks!

@120EE0980 120EE0980 deleted the replace-assert branch March 11, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants