test: make var-link-test reliable#55
Merged
borkdude merged 1 commit intoborkdude:mainfrom Mar 30, 2026
Merged
Conversation
Turf usage of matcher-combinators `embeds`. Write a helper fn to check if patterns exist in quickdoc output that does no backtracking. The backtracking was the cause of the combinatorial explosion when quickdoc output does not match expected patterns - for example, when making changes during development. Also remove "fixup" which thought it was joining long lines that quickdoc wrapped. Quickdoc doesn't seem to wrap long lines at all (well, its use of pprint might wrap, but that's not relevant to this test). Quickdoc will join lines for the toc, though. Account for this in expected patterns. This, for now, means quickdoc is not using matcher-combinators anymore. Remove it from deps. See borkdude#53 (comment)
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turf usage of matcher-combinators
embeds.Write a helper fn to check if patterns exist in quickdoc output that does no backtracking. The backtracking was the cause of the combinatorial explosion when quickdoc output does not match expected patterns - for example, when making changes during development.
Also remove "fixup" which thought it was joining long lines that quickdoc wrapped. Quickdoc doesn't seem to wrap long lines at all (well, its use of pprint might wrap, but that's not relevant to this test). Quickdoc will join lines for the toc, though.
Account for this in expected patterns.
This, for now, means quickdoc is not using matcher-combinators anymore. Remove it from deps.
See #53 (comment)