Add TCP console socket support, Windows helper scripts and documentation updates#19
Open
boscv wants to merge 25 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46d7f1fe82
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…failure on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/Interface/Socket.pm: addedIO::Socket::INETandErrnousage, support forOPENKORE_SOCKET_TCP_HOST/OPENKORE_SOCKET_TCP_PORTenvironment variables, ause_tcpflag,endpoint_desc, and separate handling for TCP vs Unix socket listen semantics including safer PID/socket file handling and informational output.tools/start-gateway.ps1: addedTest-TcpEndpointhelper and a pre-launch TCP reachability check that issues warnings if the configured OpenKore TCP console endpoint is not reachable, and improved logging/messages afterStart-Processand healthcheck.tools/start-openkore-socket-tcp.ps1: new script to start OpenKore with--interface=Socketand exportOPENKORE_SOCKET_TCP_HOST/OPENKORE_SOCKET_TCP_PORT, wait for the TCP console to open, and optionally start the gateway with the right parameters.docs/guia-acesso-remoto-pt-br.mdanddocs/guia-acesso-remoto-windows-nativo.md): clarified that the gateway requires the OpenKore console protocol (set active/input), explained thatXKore_portis not necessarily compatible, added Windows-specific instructions and examples for enabling the socket TCP endpoint and validating connectivity.Testing
Codex Task