Skip to content

Convert the Priority field from int32 to *int32 across all BPF program types (TC, TCX, XDP) and their cluster variants #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Convert the Priority field from int32 to *int32 across all BPF program types (TC, TCX, XDP) and their cluster variants #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2644849
Change Priority field to pointer type in BPF program types
andreaskaris Oct 21, 2025
d5d0038
Refactor BPF app tests to use table-driven pattern w/ helper func
andreaskaris Oct 22, 2025
bfe9fc7
Refactor network namespace cache into mockable interface
andreaskaris Oct 22, 2025
11bcd1f
test: verify priority field handling in BPF program links
andreaskaris Oct 23, 2025
bbd6448
test-integration: Add priority ordering verification for BPF links
andreaskaris Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions apis/v1alpha1/cluster_tc_program_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ type ClTcAttachInfo struct {
// +optional
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=1000
// +kubebuilder:default:=1000
Priority int32 `json:"priority,omitempty"`
Priority *int32 `json:"priority,omitempty"`

// proceedOn is an optional field and allows the user to call other TC programs
// in a chain, or not call the next program in a chain based on the exit code
Expand Down Expand Up @@ -127,7 +126,7 @@ type ClTcAttachInfoState struct {
// +required
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=1000
Priority int32 `json:"priority"`
Priority *int32 `json:"priority,omitempty"`

// proceedOn is the provisioned list of proceedOn values. proceedOn allows the
// user to call other TC programs in a chain, or not call the next program in a
Expand Down
5 changes: 2 additions & 3 deletions apis/v1alpha1/cluster_tcx_program_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ type ClTcxAttachInfo struct {
// +optional
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=1000
// +kubebuilder:default:=1000
Priority int32 `json:"priority,omitempty"`
Priority *int32 `json:"priority,omitempty"`
}

type ClTcxProgramInfoState struct {
Expand Down Expand Up @@ -110,5 +109,5 @@ type ClTcxAttachInfoState struct {
// +required
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=1000
Priority int32 `json:"priority"`
Priority *int32 `json:"priority,omitempty"`
}
5 changes: 2 additions & 3 deletions apis/v1alpha1/cluster_xdp_program_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ type ClXdpAttachInfo struct {
// +optional
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=1000
// +kubebuilder:default:=1000
Priority int32 `json:"priority,omitempty"`
Priority *int32 `json:"priority,omitempty"`

// proceedOn is an optional field and allows the user to call other XDP
// programs in a chain, or not call the next program in a chain based on the
Expand Down Expand Up @@ -107,7 +106,7 @@ type ClXdpAttachInfoState struct {
// +required
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=1000
Priority int32 `json:"priority"`
Priority *int32 `json:"priority,omitempty"`

// proceedOn is the provisioned list of proceedOn values. proceedOn allows the
// user to call other TC programs in a chain, or not call the next program in a
Expand Down
5 changes: 2 additions & 3 deletions apis/v1alpha1/tc_program_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ type TcAttachInfo struct {
// +optional
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=1000
// +kubebuilder:default:=1000
Priority int32 `json:"priority,omitempty"`
Priority *int32 `json:"priority,omitempty"`

// proceedOn is an optional field and allows the user to call other TC programs
// in a chain, or not call the next program in a chain based on the exit code
Expand Down Expand Up @@ -123,7 +122,7 @@ type TcAttachInfoState struct {
// +required
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=1000
Priority int32 `json:"priority"`
Priority *int32 `json:"priority,omitempty"`

// proceedOn is the provisioned list of proceedOn values. proceedOn allows the
// user to call other TC programs in a chain, or not call the next program in a
Expand Down
5 changes: 2 additions & 3 deletions apis/v1alpha1/tcx_program_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ type TcxAttachInfo struct {
// +optional
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=1000
// +kubebuilder:default:=1000
Priority int32 `json:"priority,omitempty"`
Priority *int32 `json:"priority,omitempty"`
}

type TcxProgramInfoState struct {
Expand Down Expand Up @@ -109,5 +108,5 @@ type TcxAttachInfoState struct {
// +required
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=1000
Priority int32 `json:"priority"`
Priority *int32 `json:"priority,omitempty"`
}
5 changes: 2 additions & 3 deletions apis/v1alpha1/xdp_program_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ type XdpAttachInfo struct {
// +optional
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=1000
// +kubebuilder:default:=1000
Priority int32 `json:"priority,omitempty"`
Priority *int32 `json:"priority,omitempty"`

// proceedOn is an optional field and allows the user to call other XDP
// programs in a chain, or not call the next program in a chain based on the
Expand Down Expand Up @@ -102,7 +101,7 @@ type XdpAttachInfoState struct {
// +required
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=1000
Priority int32 `json:"priority"`
Priority *int32 `json:"priority,omitempty"`

// proceedOn is the provisioned list of proceedOn values. proceedOn allows the
// user to call other TC programs in a chain, or not call the next program in a
Expand Down
60 changes: 60 additions & 0 deletions apis/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion bundle/manifests/bpfman-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,7 @@ metadata:
capabilities: Basic Install
categories: OpenShift Optional
containerImage: quay.io/bpfman/bpfman-operator:latest
createdAt: "2025-09-26T11:09:36Z"
createdAt: "2025-10-21T17:07:54Z"
description: The bpfman Operator is designed to manage eBPF programs for applications.
features.operators.openshift.io/cnf: "false"
features.operators.openshift.io/cni: "false"
Expand Down
3 changes: 0 additions & 3 deletions bundle/manifests/bpfman.io_bpfapplications.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,6 @@ spec:
- pods
type: object
priority:
default: 1000
description: |-
priority is an optional field and determines the execution order of the TC
program relative to other TC programs attached to the same attachment point.
Expand Down Expand Up @@ -676,7 +675,6 @@ spec:
- pods
type: object
priority:
default: 1000
description: |-
priority is an optional field and determines the execution order of the TCX
program relative to other TCX programs attached to the same attachment
Expand Down Expand Up @@ -1161,7 +1159,6 @@ spec:
- pods
type: object
priority:
default: 1000
description: |-
priority is an optional field and determines the execution order of the XDP
program relative to other XDP programs attached to the same attachment
Expand Down
3 changes: 0 additions & 3 deletions bundle/manifests/bpfman.io_bpfapplicationstates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ spec:
- interfaceName
- linkStatus
- netnsPath
- priority
- proceedOn
- shouldAttach
- uuid
Expand Down Expand Up @@ -346,7 +345,6 @@ spec:
- interfaceName
- linkStatus
- netnsPath
- priority
- shouldAttach
- uuid
type: object
Expand Down Expand Up @@ -598,7 +596,6 @@ spec:
- interfaceName
- linkStatus
- netnsPath
- priority
- proceedOn
- shouldAttach
- uuid
Expand Down
3 changes: 0 additions & 3 deletions bundle/manifests/bpfman.io_clusterbpfapplications.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,6 @@ spec:
- pods
type: object
priority:
default: 1000
description: |-
priority is an optional field and determines the execution order of the TC
program relative to other TC programs attached to the same attachment point.
Expand Down Expand Up @@ -869,7 +868,6 @@ spec:
- pods
type: object
priority:
default: 1000
description: |-
priority is an optional field and determines the execution order of the TCX
program relative to other TCX programs attached to the same attachment
Expand Down Expand Up @@ -1444,7 +1442,6 @@ spec:
- pods
type: object
priority:
default: 1000
description: |-
priority is an optional field and determines the execution order of the XDP
program relative to other XDP programs attached to the same attachment
Expand Down
3 changes: 0 additions & 3 deletions bundle/manifests/bpfman.io_clusterbpfapplicationstates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,6 @@ spec:
- direction
- interfaceName
- linkStatus
- priority
- proceedOn
- shouldAttach
- uuid
Expand Down Expand Up @@ -548,7 +547,6 @@ spec:
- direction
- interfaceName
- linkStatus
- priority
- shouldAttach
- uuid
type: object
Expand Down Expand Up @@ -872,7 +870,6 @@ spec:
required:
- interfaceName
- linkStatus
- priority
- proceedOn
- shouldAttach
- uuid
Expand Down
1 change: 1 addition & 0 deletions cmd/bpfman-agent/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ func main() {
NodeName: nodeName,
Containers: containerGetter,
Interfaces: &sync.Map{},
NetNsCache: &bpfmanagent.ReconcilerNetNsCache{},
}

if err = (&bpfmanagent.ClBpfApplicationReconciler{
Expand Down
3 changes: 0 additions & 3 deletions config/crd/bases/bpfman.io_bpfapplications.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,6 @@ spec:
- pods
type: object
priority:
default: 1000
description: |-
priority is an optional field and determines the execution order of the TC
program relative to other TC programs attached to the same attachment point.
Expand Down Expand Up @@ -676,7 +675,6 @@ spec:
- pods
type: object
priority:
default: 1000
description: |-
priority is an optional field and determines the execution order of the TCX
program relative to other TCX programs attached to the same attachment
Expand Down Expand Up @@ -1161,7 +1159,6 @@ spec:
- pods
type: object
priority:
default: 1000
description: |-
priority is an optional field and determines the execution order of the XDP
program relative to other XDP programs attached to the same attachment
Expand Down
Loading
Loading