feat: update link component; update route options fn #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tanstack-angular-router ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nartc
commented
Mar 25, 2025
| injector, | ||
| environmentInjector, | ||
| }); | ||
| this.cmp = currentCmp; | ||
| } else { | ||
| this.cmpRef?.changeDetectorRef.markForCheck(); |
There was a problem hiding this comment.
when this effect reruns for the same component for whatever reason, we'll mark this cmpRef for check just for guarantee-ness.
nartc
commented
Mar 25, 2025
Comment on lines
+63
to
+64
| this.cmp = null; | ||
| this.cmpRef = null; |
There was a problem hiding this comment.
nullify these for GC
brandonroberts
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linkdirective to have a single input: either a path or aNavigationOptionsrouteto run route fns in Injection Context:beforeLoad,loader,shouldReloadoutletto clean up on destroy