Use the one flatbuffer to store all lists [0.11.x]#493
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
Details
| Benchmark suite | Current: 3f7aa97 | Previous: 4738d3f | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2276544815 ns/iter (± 20923937) |
2252126465 ns/iter (± 13369021) |
1.01 |
rule-match-first-request/brave-list |
1006441 ns/iter (± 9030) |
1000284 ns/iter (± 8364) |
1.01 |
blocker_new/brave-list |
149232363 ns/iter (± 1596195) |
150674514 ns/iter (± 1975624) |
0.99 |
blocker_new/brave-list-deserialize |
64506480 ns/iter (± 2732717) |
62360204 ns/iter (± 1865060) |
1.03 |
memory-usage/brave-list-initial |
16282069 ns/iter (± 3) |
16225933 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-initial/max |
64817658 ns/iter (± 3) |
64817658 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/alloc-count |
1514486 ns/iter (± 3) |
1514650 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests |
2516487 ns/iter (± 3) |
2505592 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests/alloc-count |
66556 ns/iter (± 3) |
66070 ns/iter (± 3) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: 0bb327f | Previous: 4738d3f | Ratio |
|---|---|---|---|
blocker_new/brave-list-deserialize |
70978848 ns/iter (± 1126125) |
62360204 ns/iter (± 1865060) |
1.14 |
This comment was automatically generated by workflow using github-action-benchmark.
antonok-edm
approved these changes
Jun 30, 2025
|
|
||
| Self { | ||
| blocker: Blocker::new(network_filters, &blocker_options), | ||
| blocker: Blocker::from_context(filter_data_context.clone()), |
Collaborator
There was a problem hiding this comment.
this .clone() should be FilterDataContextRef::clone
atuchin-m
added a commit
that referenced
this pull request
Aug 12, 2025
The PR moves from per-NetworkList flatbuffers to a one (per-Engine). It doesn't affect the performance metrics, but opens a possibility to put cosmetic filters to the same flatbuffer. It also simplifies the serialization/deserialization code.
atuchin-m
added a commit
that referenced
this pull request
Oct 16, 2025
The PR moves from per-NetworkList flatbuffers to a one (per-Engine). It doesn't affect the performance metrics, but opens a possibility to put cosmetic filters to the same flatbuffer. It also simplifies the serialization/deserialization code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retargeted #489 to
0.11.x